Rename project to Expert #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doorgan
force-pushed
the
doorgan/rename_to_expert
branch
from
8101f11 to
306d2ca
Compare
doorgan
commented
Apr 24, 2025
| describe "excluding modules from expert dependencies" do | ||
| test "expert modules are removed", %{project: project} do | ||
| assert [] = complete(project, "Expert|") | ||
| assert [] = complete(project, "Expert.CodeIntelligence|") |
There was a problem hiding this comment.
I had to change this because there is a bug on main that causes ExUnitProperties to showup for Expert completions. The bug itself is fixed in #9 but that PR also updates the fixture project to include :stream_data as a dependency, which would make this test to return ExUnitProperties too.
This still makes sure no expert module is being suggested, so I think it's fine to keep this updated test.
App name changes: common -> forge remote_control -> engine server -> expert lexical_credo -> expert_credo Modules in `proto` and `protocol` were prefixed with Expert The namespacing prefix was changed from `LX` to `XP` The lsp meta folder was changed from `.lexical` to `.expert` The lsp logs file was changed from `lexical.log` to `expert.log` The lsp start script was chaged from `start_lexical.sh` to `start_expert.sh` The changelog was kept as-is as it reflects the project history(although it will likely be removed in favor of a new expert specific changelog file)
There is an existing bug in `main` that causes `ExUnitProperties` to be suggested for `Exper|t`. The changes in the PR this commit is part of is focused only in the renaming, so this changes the test to something that tests roughly the same, but passes. A different PR needs to fix the underlying issue here
doorgan
force-pushed
the
doorgan/rename_to_expert
branch
from
c49ad5f to
56f747a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App name changes:
common -> forge
remote_control -> engine
server -> expert
lexical_credo -> expert_credo
Modules in
protoandprotocolwere prefixed with ExpertThe namespacing prefix was changed from
LXtoXPThe lsp meta folder was changed from
.lexicalto.expertThe lsp logs file was changed from
lexical.logtoexpert.logThe lsp start script was chaged from
start_lexical.shtostart_expert.shThe changelog was kept as-is as it reflects the project history(although it will likely be removed in favor of a new expert specific changelog file)
I did not update the documentation because right now might not be the best moment to do that (#7 (comment))